fix: strip UTF-8 BOM before JSON.parse in config#384
Closed
nanaubusiness wants to merge 2 commits into
Closed
Conversation
added 2 commits
June 27, 2026 20:07
Previously uninstall deleted the entire statusLine key when it found 'ponytail-statusline' in the command string. Combined statuslines (e.g. caveman+ponytail) would lose other plugins' statuslines. Now only deletes the command field. Closes DietrichGebert#374
Unlike ponytail-activate.js and check-versions.js, this function did not strip BOM before parsing. Config files saved with BOM (common on Windows) silently failed to parse. Closes DietrichGebert#375
Owner
|
Thanks @nanaubusiness. I reconciled the #375 fix as #478 (merged) and credited you as co-author. Two changes from this PR: it uses the repo /^/ escape rather than a literal BOM character in the source (an invisible source char is fragile and can be stripped by editors/linters), and it drops the scripts/uninstall.js hunk here since that duplicates your dedicated PR #383 (which belongs to #374 and stays open on its own). Closing this in favor of #478. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike ponytail-activate.js and check-versions.js, this function did not strip BOM before parsing. Config files saved with BOM (common on Windows) silently failed to parse, ignoring user settings.
Closes #375